-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update soroban xdr #4704
Update soroban xdr #4704
Conversation
The integration tests should be fixed I am also going to disable the Soroban RPC tests in this repo, because the fixes/updates required are at the new tools repo ( stellar/stellar-cli#274 ) |
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.4.1-1097.4e813f20e.focal~soroban | ||
PROTOCOL_20_CORE_DOCKER_IMG: sreuland/stellar-core:19.4.1-1097.4e813f20e.focal-soroban | ||
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.5.1-1131.f55f88376.focal~soroban | ||
PROTOCOL_20_CORE_DOCKER_IMG: 2opremio/stellar-core:19.5.1-1131.f55f88376.focal-soroban |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have these built somewhere official, not on just our personal dockerhubs... But that's not really an issue with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I didn't find a better way since the docker repo where builds are put is internal.
LGTM, but I can't approve it as I'm an author 😂 |
It seems like the apt repo is acting up:
|
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Updated xdr to commit
026c9cd074bdb28ddde8ee52f2a4502d9e518a09
Had to change a couple small implementations to adapt.
Why
OperationEvents change is required for #4694
We probably want to update it for the release anyway.
Todo