historyarchive: Make the library target the same log as Horizon #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
pushed a commit
to sreuland/go
that referenced
this pull request
Jan 29, 2024
…lar#5178) * Change logging provider to Horizon's default rather than logrus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When using a cache for history archives, use the same log target to match Horizon.
Why
Logs from this package do not appear in Horizon's logs.
Known limitations
This means library users need to use the same logging setup as Horizon, but this is an attempt at a temporary fix, so this is an acceptable quirk for now.