Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest: Add metrics for ingestion loaders #5209

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Feb 14, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #5154

We do not have any metrics capturing how long it takes to run the ingestion loaders:

https://github.com/stellar/go/blob/release-horizon-v2.28.0/services/horizon/internal/ingest/group_processors.go#L101-L105

This commit adds prometheus metrics for the duration of each loader so we can determine how much of ingestion is spent in the loaders vs the processors. We also added prometheus metrics capturing how many records were queried and inserted during the execution of each loader.

Known limitations

[N/A]

@sreuland
Copy link
Contributor

sreuland commented Feb 21, 2024

since 2.28.3 went out last week unfortunately on a bit of rush, this needs to target master now

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tamirms
Copy link
Contributor Author

tamirms commented Feb 21, 2024

@sreuland I think I have addressed all your feedback, could you take another look?

@sreuland
Copy link
Contributor

@sreuland I think I have addressed all your feedback, could you take another look?

looks good, and thanks for consideration on suggestions!

do need to re-target this pr to merge to master the 2.28.3 branch has already been released.

@tamirms tamirms changed the base branch from release-horizon-v2.28.3 to master February 21, 2024 20:13
@tamirms tamirms merged commit b0d394e into stellar:master Feb 21, 2024
29 checks passed
@tamirms tamirms deleted the loader-metrics branch February 21, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for ingestion loaders
3 participants