Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest: Log tx meta when ingestion failures occur #5268

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Mar 29, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

close #5257

Logs tx meta whenever there is an error encountered in any of the change processors. See below for an example log message:

time="2024-03-29T17:32:21.236Z" level=error msg="error processing change" change="Change{Type: LedgerEntryTypeAccount, Pre: AAAACgAAAAAAAAAAti4BUQwWdyedpy5t9JKtojIKzu3WM2ADd4b47X9SB1oAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=, Post: AAAACwAAAAAAAAAAti4BUQwWdyedpy5t9JKtojIKzu3WM2ADd4b47X9SB1oAAAAAAAAAyAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=}" error="transient error" pid=90088 sequence=1 service=ingest

Why

See #5257

Known limitations

[N/A]

@tamirms tamirms requested a review from a team March 29, 2024 17:41
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tamirms tamirms merged commit a30c441 into stellar:master Mar 29, 2024
23 checks passed
@tamirms tamirms deleted the log-meta-errors branch March 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services/horizon: log meta when ingestion engine failures occur
2 participants