ingest/ledgerbackend: tweak enforcing toml parameters and tests #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable `ENABLE_DIAGNOSTICS_FOR_TX_SUBMISSION` when enforcing soroban diagnostics (needed for soroban-rpc) * Add `EnforceSorobanTransactionMetaExtV1` toml parameter, so that `EMIT_SOROBAN_TRANSACTION_META_EXT_V1` is enabled by default (needed for soroban-rpcs new `getFeeStats` endpoint). See stellar/stellar-rpc#172 * Mock core version and protocol in tests so that toml generation is more realistic
tamirms
approved these changes
May 16, 2024
2opremio
added a commit
to 2opremio/soroban-rpc
that referenced
this pull request
May 16, 2024
2opremio
added a commit
to 2opremio/soroban-rpc
that referenced
this pull request
May 16, 2024
2opremio
added a commit
to stellar/stellar-rpc
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_DIAGNOSTICS_FOR_TX_SUBMISSIONwhen enforcing soroban diagnostics (needed for soroban-rpc)EnforceSorobanTransactionMetaExtV1toml parameter, so thatEMIT_SOROBAN_TRANSACTION_META_EXT_V1is enabled by default (needed for soroban-rpcs newgetFeeStatsendpoint). See Add getFeeStats method stellar-rpc#172