Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stable Protocol 20 release (both XDR and RPC schemas) #710

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 31, 2023

The work is complete, but we need the final ✔️ on this being the actual final version.

Note that this PR was already approved in #704.

Shaptic and others added 3 commits October 23, 2023 11:35
XDR has been upgraded to the latest stable version. This is mostly renames, but
it includes the following relevant breaking changes:
  - `Operation.bumpFootprintExpiration` is now `extendFootprintTtl` and its
  `ledgersToExpire` field is now named `extendTo`, but it serves the same
  purpose. - `xdr.ContractExecutable.contractExecutableToken` is now
  `contractExecutableStellarAsset` - `xdr.SorobanTransactionData.refundableFee`
  is now `resourceFee` - In turn, `SorobanDataBuilder.setRefundableFee` is now
  `setResourceFee` - This new fee encompasses the entirety of the
  Soroban-related resource fees. Note that this is distinct from the
  "network-inclusion" fee that you would set on your transaction (i.e.
  `TransactionBuilder(..., { fee: ... })`). - In TypeScript, the
  `Operation.BumpFootprintExpiration` is now `Operation.ExtendFootprintTTL`

Commit: stellar/stellar-xdr @ 6a620d1
@Shaptic Shaptic self-assigned this Oct 31, 2023
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 31, 2023
Copy link

github-actions bot commented Oct 31, 2023

Size Change: +25.7 kB (+1%)

Total Size: 3.19 MB

Filename Size Change
dist/stellar-base.js 2.34 MB +19.8 kB (+1%)
dist/stellar-base.min.js 849 kB +5.91 kB (+1%)

compressed-size-action

@Shaptic Shaptic marked this pull request as ready for review December 1, 2023 21:27
@Shaptic Shaptic requested a review from sreuland December 1, 2023 21:27
@Shaptic Shaptic changed the title [Draft] Upgrade XDR to the final stable version Upgrade XDR to the final stable version Dec 1, 2023
@Shaptic Shaptic changed the title Upgrade XDR to the final stable version Add support for stable Protocol 20 release (both XDR and RPC schemas) Dec 1, 2023
Makefile Outdated Show resolved Hide resolved
@Shaptic Shaptic merged commit 5766516 into master Dec 5, 2023
4 checks passed
@Shaptic Shaptic deleted the stable branch December 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants