-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stable Protocol 20 release (both XDR and RPC schemas) #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDR has been upgraded to the latest stable version. This is mostly renames, but it includes the following relevant breaking changes: - `Operation.bumpFootprintExpiration` is now `extendFootprintTtl` and its `ledgersToExpire` field is now named `extendTo`, but it serves the same purpose. - `xdr.ContractExecutable.contractExecutableToken` is now `contractExecutableStellarAsset` - `xdr.SorobanTransactionData.refundableFee` is now `resourceFee` - In turn, `SorobanDataBuilder.setRefundableFee` is now `setResourceFee` - This new fee encompasses the entirety of the Soroban-related resource fees. Note that this is distinct from the "network-inclusion" fee that you would set on your transaction (i.e. `TransactionBuilder(..., { fee: ... })`). - In TypeScript, the `Operation.BumpFootprintExpiration` is now `Operation.ExtendFootprintTTL` Commit: stellar/stellar-xdr @ 6a620d1
Size Change: +25.7 kB (+1%) Total Size: 3.19 MB
|
This was referenced Oct 31, 2023
* Do all package renames in the source code * Misc. jsdoc fixups
Shaptic
changed the title
[Draft] Upgrade XDR to the final stable version
Upgrade XDR to the final stable version
Dec 1, 2023
Shaptic
changed the title
Upgrade XDR to the final stable version
Add support for stable Protocol 20 release (both XDR and RPC schemas)
Dec 1, 2023
sreuland
reviewed
Dec 4, 2023
sreuland
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work is complete, but we need the final ✔️ on this being the actual final version.
Note that this PR was already approved in #704.