Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host::check_val_integrity could/should error on bad tags #1029

Closed
brson opened this issue Sep 1, 2023 · 2 comments
Closed

Host::check_val_integrity could/should error on bad tags #1029

brson opened this issue Sep 1, 2023 · 2 comments
Assignees
@graydon

Comments

@brson
Copy link
Contributor

brson commented Sep 1, 2023

Host::check_val_integrity is called on all Vals passing through the Host. This avoids contracts receiving adversarial "weird" Vals from other contracts.

At the moment it appears to only reject Vals that are objects that have invalid references.

Another type of unexpected Val is one with an invalid tag (Tag::Bad). The host could also reject these.

cc "adversarial" vals for fuzzing stellar/rs-soroban-sdk#1052
@graydon graydon self-assigned this Sep 1, 2023
@graydon
Copy link
Contributor

graydon commented Sep 1, 2023

Agreed, good idea.

graydon added a commit that referenced this issue Sep 1, 2023
@graydon
Reject vals with invalid tags, fix #1029
643f92f
@graydon graydon mentioned this issue Sep 1, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 1, 2023
@graydon
Reject vals with invalid tags, fix #1029 (#1033)
7f632cd
@graydon
Copy link
Contributor

graydon commented Sep 5, 2023

Fixed in #1033

@graydon graydon closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @brson