Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawing PRNG bytes is unmetered #1059

Closed
jayz22 opened this issue Sep 13, 2023 · 2 comments · Fixed by #1079
Closed

Drawing PRNG bytes is unmetered #1059

jayz22 opened this issue Sep 13, 2023 · 2 comments · Fixed by #1079

Comments

@jayz22
Copy link
Contributor

jayz22 commented Sep 13, 2023

rs-soroban-env/soroban-env-host/src/host/prng.rs

Line 88 in f19ef13

// TODO: add a ContractCostType for drawing PRNG bytes

@jayz22 jayz22 changed the title PRNG is unmetered Drawing PRNG bytes is unmetered Sep 19, 2023
@jayz22
Copy link
Contributor Author

jayz22 commented Sep 19, 2023

This will require adding a new variant ContractCostType::PrngDrawBytes in the xdr, and doing calibration add a new cost model for it in the Budget.

@anupsdf
Copy link
Contributor

anupsdf commented Sep 19, 2023

The XDR change will go to both curr and next branches I think.

This was referenced Sep 20, 2023
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2023
@jayz22
Calibration for PRNG and charge budget (#1079)
f593800 
### What

Resolves #1059

~Still waiting on the xdr changes
(stellar/stellar-xdr#151 and rs-stellar-xdr) to
use the right cost type. Currently using Sha256 cost type as
placeholder.~

Added a couple of minor improvements and cleanups.

### Why

[TODO: Why this change is being made. Include any context required to
understand the why.]

### Known limitations

[TODO or N/A]
@jayz22 jayz22 mentioned this issue Sep 23, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calibration for PRNG and charge budget jayz22/rs-soroban-env
2 participants
@jayz22 @anupsdf