Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type: Map: Host reject ScMaps that contain duplicate keys #222

Closed
leighmcculloch opened this issue Jul 15, 2022 · 2 comments
Closed

Type: Map: Host reject ScMaps that contain duplicate keys #222

leighmcculloch opened this issue Jul 15, 2022 · 2 comments

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Jul 15, 2022 •
edited
Loading

What

Host should reject ScMaps that contain duplicate keys.

Why

Maps with duplicate keys are an indication of bad/wrong input. They're a footgun because they are unlikely to have been signed correctly. They will also not round-trip serialize, so the input and output of a contract fn that passes the structure straight through will not be identical XDR bytes.

Related to #221 stellar/rs-stellar-xdr#98

cc @graydon @jonjove @jayz22
@leighmcculloch leighmcculloch mentioned this issue Jul 15, 2022
Closed
@leighmcculloch
Copy link
Member Author

Dependent on stellar/rs-stellar-xdr#106

@leighmcculloch leighmcculloch changed the title Type: Map: Host reject ScMaps that contain duplicate keys Host reject ScVals that are invalid Jul 15, 2022
@leighmcculloch leighmcculloch changed the title Host reject ScVals that are invalid Type: Map: Host reject ScMaps that contain duplicate keys Jul 15, 2022
@leighmcculloch
Copy link
Member Author

Superseded by #223

@leighmcculloch leighmcculloch closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2022
@leighmcculloch leighmcculloch mentioned this issue Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leighmcculloch