Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host reject ScVals that are invalid #223

Closed
leighmcculloch opened this issue Jul 15, 2022 · 1 comment · Fixed by #929
Closed

Host reject ScVals that are invalid #223

leighmcculloch opened this issue Jul 15, 2022 · 1 comment · Fixed by #929
Assignees
@graydon

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Jul 15, 2022 •
edited
Loading

Supersedes #221 #222

Dependent on stellar/rs-stellar-xdr#106

cc @graydon @jonjove @jayz22
This was referenced Jul 15, 2022
Closed
Closed
@graydon graydon self-assigned this Jul 15, 2022
@graydon
Copy link
Contributor

graydon commented Jul 5, 2023

We actually can't call <ScVal as xdr::Validate>::validate on ScVals entering the system because that's not a metered function; but we do already perform equivalent validations during ScVal injections. We have a test for the symbol case but seemingly not the map-order case. I'll add another test.

graydon added a commit that referenced this issue Jul 5, 2023
@graydon
Add testcase for out-of-order scmaps, fix #223.
fb99378
@graydon graydon mentioned this issue Jul 5, 2023
Merged
graydon added a commit that referenced this issue Jul 5, 2023
@graydon
Add testcase for out-of-order scmaps, fix #223. (#929)
dace962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add testcase for out-of-order scmaps, fix #223. stellar/rs-soroban-env
2 participants
@graydon @leighmcculloch