Add "next" feature to crates using xdr directly or indirectly #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stellar-core has support for developing "two versions at once" of the protocol: a "curr" version which is soon-to-ship (for point releases, hotfixes or work we're very certain we're done working on) and a "next" version which is experimental / not-to-ship. These are both available in the same codebase and switched between using flags, not branches. The point of this arrangement is to avoid having to maintain potentially-diverging branches (at least of most of the code, the XDR is branched): most code can have everyone work on head and just switch configs when we switch tasks between future-work and current-release work.
This PR adds support for this curr/next split to the env crates, selectively enabling either the curr or next XDR and adjusting the declared protocol version (and unfortunately also all the test wasms compiled against those).
It may seem like it might be overkill, but there are 3 increasingly-serious reasons why I think this is necessary:
Obviously this is not the only way forward, and there's a limit to how far we take it (eg. apparently horizon prefers to work on branches and this is not going to propagate through to them) but .. I think given the arguments above this is the right current choice.