Code review on fees, crypto, prng, dispatch #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
graydon-code-review-7
branch
from
8526d73
to
019ffcf
Compare
graydon
changed the title
graydon
changed the title
dmkozh
approved these changes
Oct 12, 2023
graydon
force-pushed
the
graydon-code-review-7
branch
from
136057a
to
43e7d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing critical here, just some defensive arithmetic and a few edge cases that I wasn't sure about in fees (possibly a bug? I wasn't sure in conversation with @dmkozh but in any case refactored for readability), plus one real pub-to-pub(crate) in crypto and one in prng.