Remove bad LEs #1114
Merged
Remove bad LEs #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes. Also fix a missing charge for substructure on Account entries.
dmkozh
approved these changes
Oct 16, 2023
jayz22
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes out of some review on compare.rs: we were supporting a lot of LE types in the code that are not ever supposed to occur. It's better to treat the presence of those cases as internal errors than have dead code "supporting" them possibly incorrectly.
Also eliminates comparison of LEs altogether. They were only being compared because of older constraints on MeteredOrdMap wanting its value type to be comparable. That's not necessary for LEs (in the Storage map), only Vals (in HostMaps) in order to have Map be ordered itself (because Val must be ordered). Turns out we'd already relaxed the requirement on MeteredOrdMap's value type to not have to be comparable. So all the LE-ordering code was dead anyway, which is good because they were all being treated as calls to Ord on fixed size types, but they weren't all fixed size types.
Also fixed a missing case in metered_clone, where we weren't charging for substructure of AccountEntries.
I'm not sure this is all that needs to be done for these files. I'm just out of time for tonight. Will continue reviewing on monday but figured I should get this started now.