Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that ensures that SAC reentry is not possible. #1179

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Nov 6, 2023

What

Add a test that ensures that SAC reentry is not possible.

The test uses a custom account that does a token transfer in its __check_auth, which causes reentry in case if it's called during the operation on that token.

Why

Improving test coverage (#1166)

Known limitations

N/A

@dmkozh dmkozh requested review from graydon, sisuresh and a team as code owners November 6, 2023 15:56
@dmkozh dmkozh enabled auto-merge November 6, 2023 20:06
@dmkozh dmkozh added this pull request to the merge queue Nov 6, 2023
Merged via the queue into stellar:main with commit f799245 Nov 6, 2023
10 checks passed
@dmkozh dmkozh deleted the sac_reentry branch November 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants