Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that try to build a deep host stack. #1185

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Nov 8, 2023

What

Add tests that try to build a deep host stack.

The tests combine sub-contract calls with XDR serialization (these happen to have their depth limited independently). Sub-contract calls also go through auth subsystem in order to increase the number of stack frames per contract invocation.

Resolves #1153

Why

Improving test coverage, making sure there is no host stack overflow.

Known limitations

N/A

The tests combine sub-contract calls with XDR serialization (these happen to have their depth limited independently). Sub-contract calls also go through auth subsystem in order to increase the number of stack frames per contract invocation.
@dmkozh dmkozh requested review from graydon, sisuresh and a team as code owners November 8, 2023 19:06
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed just the toml/build-script part of the change for the moment and suggest a couple changes.

Cargo.toml Outdated Show resolved Hide resolved
soroban-env-host/build.rs Outdated Show resolved Hide resolved
@graydon graydon added this pull request to the merge queue Nov 9, 2023
Merged via the queue into stellar:main with commit af15c95 Nov 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] Build the largest host stack possible within the budget limits
3 participants