Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for more wasmi trap conditions #1186

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Add tests for more wasmi trap conditions #1186

merged 2 commits into from
Nov 9, 2023

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Nov 8, 2023

What

Resolves #1143

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@jayz22 jayz22 requested review from graydon, sisuresh and a team as code owners November 8, 2023 19:21
dmkozh
dmkozh reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is supposed to resolve the cost issue, but I couldn't find tests for IndirectCallToNull, IntegerDivideByZero, IntegerOverflow - would you mind pointing these to me? (if they're already implemented, of course)

jayz22
jayz22 commented Nov 9, 2023
View reviewed changes
soroban-env-host/src/test/hostile.rs Show resolved Hide resolved
soroban-env-host/src/test/hostile.rs Show resolved Hide resolved
soroban-env-host/src/test/hostile.rs Show resolved Hide resolved
soroban-env-host/src/test/hostile.rs Show resolved Hide resolved
soroban-env-host/src/test/hostile.rs Show resolved Hide resolved
@jayz22
Copy link
Contributor Author

jayz22 commented Nov 9, 2023

@dmkozh I've commented in the PR on which test case covers which wasm error. The wasmi::Error are remapped into host error types so some of them aren't too obvious.

@dmkozh dmkozh added this pull request to the merge queue Nov 9, 2023
Merged via the queue into stellar:main with commit 6f69811 Nov 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@graydon graydon Awaiting requested review from graydon graydon is a code owner

@sisuresh sisuresh Awaiting requested review from sisuresh sisuresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] test more wasmi trap conditions
2 participants
@jayz22 @dmkozh