Add a contract that allows materializing arbitrarily large values. #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for end-to-end testing from Core. We could also cover the same cases in host tests, but Core tests are higher priority as they potentially exercise additional logic (e2e invoke, Rust bridge).
- Don't try to attach non-serializable value to the error in `from_host_val`. This led to infinite recursion in diagnostics mode (that still worked ok-ish thanks to shadow budget though) - Output the number of elided events
sisuresh
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a contract that allows materializing arbitrarily large values.
This is for end-to-end testing from Core (stellar/stellar-core#4004). We could also cover the same cases in the host tests, but Core tests are higher priority as they potentially exercise additional logic (e2e invoke, Rust bridge).
Also did a bit of diagnostics cleanup based on findings from running the core tests.
Why
Enhancing test coverage.
Known limitations
N/A