-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro for testing host function dispatch with bad inputs #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
requested review from
graydon,
sisuresh,
dmkozh and
a team
as code owners
November 15, 2023 03:12
New tests generated:
|
jayz22
force-pushed
the
write-tests4
branch
4 times, most recently
from
November 15, 2023 22:32
e74ac6d
to
f9445e0
Compare
graydon
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I'm going to work on some followups to improve the integrity checking but I'm really happy to see improved input coverage like this, thanks!
graydon
force-pushed
the
write-tests4
branch
from
November 16, 2023 03:12
f9445e0
to
45cde99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #1155
Add a macro that
Catches and fixes three issues where invalid object handle isn't caught early enough:
contract_event
,require_auth
,require_auth_for_args
.