Observe more things #1224
Merged
Observe more things #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Nov 17, 2023
dmkozh
approved these changes
Nov 17, 2023
graydon
force-pushed
the
observe-more-things
branch
from
07e4c5a
to
732b5c4
Compare
graydon
force-pushed
the
observe-more-things
branch
from
732b5c4
to
78090eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several new observation types to the test observer. The most important part is that it now observes the state of the auth manager, which is reports with two separate values: a (size,hash) pair for the current auth stack, and a (size,hash) pair for the sum of all the trackers. I think this is probably the most useful way to eyeball changes, but @dmkozh should confirm (and maybe give a look at the recorded observation traces here to see if they make sense to you)