Fix the invoker contract auth rollback logic and cover it in the tests. #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides the 'obvious' issue of missing the code that actually performs rollback, there was much more subtle issue of incorrect ordering between `rollback` and `pop_frame`. To avoid this I've moved the snapshots/rollbacks to the auth manager, so that it's not possible to accidentally mess up that order.
graydon
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the invoker contract auth rollback logic and cover it in the tests.
Besides the 'obvious' issue of missing the code that actually performs rollback, there was much more subtle issue of incorrect ordering between
rollbackandpop_frame. To avoid this I've moved the snapshots/rollbacks to the auth manager, so that it's not possible to accidentally mess up that order.Resolves #1252
Why
Bug fix/adding tests
Known limitations
N/A