Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off wasm_reference_types in Wasmi #1291

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Dec 5, 2023

What

Disable wasmi reference_typesand make all wasmi feature selections explicit.
Also did a pass-by clean up on the fuel configs code.

Why

bulk_memory and reference_types are both post-MVP features.
We use 1 extensively for object init/copy between host and guest.
We do not use 2 at all. We are not using ExternRef and we are limiting table count to 1 (via resource limiter).

Known limitations

[TODO or N/A]

Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally ok but needs a protocol gate (at least on the part that's a change -- I take it the bulk-memory one is not a functional change, just setting explicitly what is already being set implicitly?)

@jayz22 jayz22 force-pushed the vm-config branch 2 times, most recently from 0d7a74f to e823588 Compare January 31, 2024 03:17
@graydon graydon added this pull request to the merge queue Jan 31, 2024
Merged via the queue into stellar:main with commit de562ab Jan 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants