Turn off wasm_reference_types
in Wasmi
#1291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Disable wasmi
reference_types
and make all wasmi feature selections explicit.Also did a pass-by clean up on the fuel configs code.
Why
bulk_memory
andreference_types
are both post-MVP features.We use 1 extensively for object init/copy between host and guest.
We do not use 2 at all. We are not using
ExternRef
and we are limiting table count to 1 (via resource limiter).Known limitations
[TODO or N/A]