Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-wasms to use release sdk/env and add contract that can transfer using the SAC #1299

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Dec 14, 2023

Required for #912.

I'm surprised that the test wasms were still being built with rc2 and that we didn't have any issues... (EDIT: nvm we use a local patch for env and sdk when building test wasms)

@sisuresh sisuresh requested review from a team, graydon and dmkozh as code owners December 14, 2023 21:18
@sisuresh
Copy link
Contributor Author

@jayz22 I think the the observation updates in this PR are due to the cost model updates. Is this expected?

@dmkozh
Copy link
Contributor

dmkozh commented Dec 14, 2023

Do we really need to update all the Wasms? Why not just add the new one?

@sisuresh
Copy link
Contributor Author

Do we really need to update all the Wasms? Why not just add the new one?

Good point. I thought I had to make an update because rc2 was specified in the TOML file, but that was wrong. Updated.

@dmkozh
Copy link
Contributor

dmkozh commented Dec 14, 2023

I thought I had to make an update because rc2 was specified in the TOML file, but that was wrong

FWIW now that the protocol is frozen, these Wasms can be considered frozen as well, at least in terms of the SDK/env versions (we should be able to run them in every future versions).

@sisuresh
Copy link
Contributor Author

I thought I had to make an update because rc2 was specified in the TOML file, but that was wrong

FWIW now that the protocol is frozen, these Wasms can be considered frozen as well, at least in terms of the SDK/env versions (we should be able to run them in every future versions).

Is this true? We can technically update the sdk version and still rebuild a v20 compatible contract right?

@sisuresh sisuresh added this pull request to the merge queue Dec 14, 2023
@dmkozh
Copy link
Contributor

dmkozh commented Dec 14, 2023

Is this true? We can technically update the sdk version and still rebuild a v20 compatible contract right?

Sure, I mean that the old contracts have to remain compatible. Newer contracts should of course be compatible as well. Just saying that it's valuable to keep the older contracts around as a simple sanity check.

Merged via the queue into stellar:main with commit 7569e33 Dec 14, 2023
10 checks passed
@sisuresh sisuresh deleted the contract-transfer branch December 14, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants