Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rust-version compilation issue #1335

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

sisuresh
Copy link
Contributor

What

Trying to regenerate the test wasms results in the following error.

error: failed to parse manifest at `/Users/siddharthsuresh/dev/rs-soroban-env/soroban-test-wasms/wasm-workspace/write_upgrade_bytes/Cargo.toml`

Caused by:
  error inheriting `rust_version` from workspace root manifest's `workspace.package.rust_version`

Caused by:
  `workspace.package.rust-version` was not defined

I think the issue has something to do with the limitations with workspace inheritance, but I'm not really sure. @leighmcculloch please let me know if you know of a better solution than just setting the version again explicitly in each test wasm.

@sisuresh sisuresh requested a review from a team as a code owner January 26, 2024 21:42
@dmkozh
Copy link
Contributor

dmkozh commented Jan 26, 2024

Trying to regenerate the test wasms results in the following error.

I just wanted to remind that we should not regenerate Wasms for protocol 20 anymore (unless it's necessary to modify them) - I suppose these are necessary to generate p21 Wasms, right?

@sisuresh
Copy link
Contributor Author

Trying to regenerate the test wasms results in the following error.

I just wanted to remind that we should not regenerate Wasms for protocol 20 anymore (unless it's necessary to modify them) - I suppose these are necessary to generate p21 Wasms, right?

Yeah that's why I didn't commit the regenerated wasm files. If we want to regenerate for v21, we'll run into the issue mentioned here.

@leighmcculloch
Copy link
Member

I think the issue has something to do with the limitations with workspace inheritance, but I'm not really sure. @leighmcculloch please let me know if you know of a better solution than just setting the version again explicitly in each test wasm.

I don't think there's anyway to pull this from the top-level workspace, but you could add it as a property of the wasm-workspace and have the projects reference it. At least then it would only be in two places.

@sisuresh sisuresh requested review from leighmcculloch and removed request for leighmcculloch February 28, 2024 19:26
@sisuresh sisuresh added this pull request to the merge queue Feb 28, 2024
Merged via the queue into stellar:main with commit 734c2ed Feb 28, 2024
13 checks passed
@sisuresh sisuresh deleted the fix-test-wasms branch February 28, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants