Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix a few small but protocol-breaking metering issues discovered by the security review:
i. auth entry charging the wrong amount #1297
ii. (not protocol breaking) auth
snapshot()
function charge after allocationiii. auth manager not charging
RefCell
wrapping.I also did a clean up by wrapping the
with_capacity
method with metering into a newMeteredContainer::with_metered_capacity
method, which makes sure bugs like (i) and (ii) above cannot happen.Unfortunately these breaks a lot of existing observations that depends on auth, basically all
mem_bytes
have increased by 8 (size of the RefCell counter) andcpu_insns
have increased by 2, which is caused by fixing (iii).Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]