Bump tracy-client to 0.17 to expose delayed-init feature #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerweller
approved these changes
Sep 17, 2024
leighmcculloch
approved these changes
Sep 17, 2024
| "windows-targets", | ||
| "windows-targets 0.48.5", |
There was a problem hiding this comment.
This seems not great. Would be good for deps if we can resolve in a way to not require multiple windows-targets.
There was a problem hiding this comment.
hmm. they're dev-deps of tracy-client-sys when it's being tested under loom. I agree I don't love the duplication in the lockfile but none of this is making it into any actual builds. I've tried updating quite a lot of things-that-cause-the-dependency and ultimately I get blocked on one that's just quite out of date, textplots -> drawille -> colored -> windows-sys 0.48 -> windows-targets 0.48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the tracy-client crate to 0.17, so that we can access the
delayed-initfeature (it's not present in 0.16.4 but necessary to use with core). Previously we were patching this dep entirely with a local vendored build of tracy in core, so this potentially moves us closer to upstream (if it work).