Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format contract id in fn_call event topic #1465

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Format contract id in fn_call event topic #1465

merged 2 commits into from
Sep 18, 2024

Conversation

sisuresh
Copy link
Contributor

What

Resolves #1463

Before

Event log (newest first):
0: [Diagnostic Event] contract:CAXDPD4A5ANAASQ2U74RBW7ULGB3TS5SGSAFYPN6O2R2IJKGEX22SWUS, topics:[error, Error(Contract, https://github.com/stellar/rs-soroban-env/pull/8)], data:["negative amount is not allowed", -1]
1: [Diagnostic Event] topics:[fn_call, Bytes(2e378f80e81a004a1aa7f910dbf45983b9cbb234805c3dbe76a3a4254625f5a9), mint], data:[GD4YHMIZ7IGW7E4XJ4TXIJPLJU255JXPM2PKTV6H4PA4N5RTM6T2R73D, -1]
2: [Diagnostic Event] contract:CAXDPD4A5ANAASQ2U74RBW7ULGB3TS5SGSAFYPN6O2R2IJKGEX22SWUS, topics:[fn_return, init_asset], data:Void
3: [Diagnostic Event] topics:[fn_call, Bytes(2e378f80e81a004a1aa7f910dbf45983b9cbb234805c3dbe76a3a4254625f5a9), init_asset], data:Bytes(00000001616161610000000000fc065517dbbca3e37ec0e97dbfcd80e6bcdfdac732be1e4152b259f1f7ea88)

After

Event log (newest first):
0: [Diagnostic Event] contract:CAXDPD4A5ANAASQ2U74RBW7ULGB3TS5SGSAFYPN6O2R2IJKGEX22SWUS, topics:[error, Error(Contract, https://github.com/stellar/rs-soroban-env/pull/8)], data:["negative amount is not allowed", -1]
1: [Diagnostic Event] topics:[fn_call, CAXDPD4A5ANAASQ2U74RBW7ULGB3TS5SGSAFYPN6O2R2IJKGEX22SWUS, mint], data:[GD4YHMIZ7IGW7E4XJ4TXIJPLJU255JXPM2PKTV6H4PA4N5RTM6T2R73D, -1]
2: [Diagnostic Event] contract:CAXDPD4A5ANAASQ2U74RBW7ULGB3TS5SGSAFYPN6O2R2IJKGEX22SWUS, topics:[fn_return, init_asset], data:Void
3: [Diagnostic Event] topics:[fn_call, CAXDPD4A5ANAASQ2U74RBW7ULGB3TS5SGSAFYPN6O2R2IJKGEX22SWUS, init_asset], data:Bytes(00000001616161610000000000fc065517dbbca3e37ec0e97dbfcd80e6bcdfdac732be1e4152b259f1f7ea88)

@sisuresh sisuresh removed the request for review from graydon September 17, 2024 17:39
@sisuresh sisuresh marked this pull request as draft September 17, 2024 17:40
@sisuresh sisuresh marked this pull request as ready for review September 17, 2024 17:41
dmkozh
dmkozh reviewed Sep 18, 2024
View reviewed changes
soroban-env-host/src/events/mod.rs Show resolved Hide resolved
soroban-env-host/src/events/mod.rs Outdated Show resolved Hide resolved
soroban-env-host/src/events/mod.rs Outdated Show resolved Hide resolved
@sisuresh sisuresh added this pull request to the merge queue Sep 18, 2024
Merged via the queue into stellar:main with commit cf8023a Sep 18, 2024
12 checks passed
@sisuresh sisuresh deleted the fn_call-topic branch September 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@leighmcculloch leighmcculloch Awaiting requested review from leighmcculloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract ID prints incorrect in stack trace
2 participants
@sisuresh @dmkozh