Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Auth Next for host fns #823

Merged
merged 12 commits into from
May 31, 2023
Merged

Support Auth Next for host fns #823

merged 12 commits into from
May 31, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented May 31, 2023

What

  • Add support for host fn frames in auth manager
  • Add support for host fns in custom account contracts
  • Adapt to the XDR refactoring in Changes to auth-related XDR and a bit of cleanup. stellar-xdr#95
  • Use Address instead of 32-bytes for most of the host functions
  • Modify/add host fns to be able to perform the operations that currently are only available via a top-level invocation only (create contracts on behalf of any address, create asset contracts, upload wasm).

Why

  • Improve consistency of how authorization works across the system (unify the way host fns and contract fns are authorized).
  • Reach feature parity between the host interface available to contracts and host interface invokable from classic ops

Known limitations

N/A

@dmkozh
Refactor host to support authorizing host functions and use Address…
44c4c0a 
… more.

- Adapt to the XDR refactoring
- Add support for host fn frames in auth manager
- Use `Address` instead of 32-bytes for most of the host functions
- Modify/add host fns to be able to perform all the operations (create asset contracts, upload wasm)
@dmkozh
Support for some new XDR type metered clones/comparisons.
a020345 
Also updated some outdated size values.
@dmkozh
Test wasms update
80d4824
@dmkozh
Test framework refactor and simple updates.
41ede70
@dmkozh
Auth-related test updates.
27329fa
@dmkozh
WIP cargo update
8f7d89e
@dmkozh dmkozh mentioned this pull request May 31, 2023
Merged
@dmkozh dmkozh marked this pull request as ready for review May 31, 2023 16:49
@dmkozh dmkozh requested review from graydon, sisuresh and a team as code owners May 31, 2023 16:49
dmkozh and others added 2 commits May 31, 2023 13:46
@dmkozh
!fixup update synth wasm
2dd7e04
@dmkozh @sisuresh
Update soroban-env-host/src/host/frame.rs
c6475c8 
Co-authored-by: Siddharth Suresh <siddharth@stellar.org>
@dmkozh dmkozh merged commit 30263e9 into stellar:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisuresh sisuresh sisuresh approved these changes

@graydon graydon Awaiting requested review from graydon graydon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmkozh @sisuresh