Refactor authorization manager to only maintain mutable borrow on minimal amount of fields #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imal amount of fields. This avoids auth manager re-borrow hack and allows calling `require_auth` from within `__check_auth`. The latter might not be the most important feature, but it makes things more consistent.
dmkozh
force-pushed
the
auth_manager_borrow
branch
from
f0d7b1d
to
6041fe6
Compare
This is to make sure there is no issue with invoker contract cleanup that didn't have any frames pushed.
anupsdf
reviewed
Jul 11, 2023
graydon
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor authorization manager to only maintain mutable borrow on minimal amount of fields.
Why
This avoids auth manager re-borrow hack and allows calling
require_authfrom within__check_auth. The latter might not be the most important feature, but it makes things more consistent.Known limitations
N/A