Make del_contract_data no-op for removing non-existent instance storage key.
#951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage key. This was inconsistent with persistent/temp storage, which doesn't return error for non-existent keys.
sisuresh
reviewed
Jul 14, 2023
sisuresh
approved these changes
Jul 14, 2023
Co-authored-by: Siddharth Suresh <siddharth@stellar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make
del_contract_datano-op for removing non-existent instance storage key.Resolves #949
Why
This was inconsistent with persistent/temp storage, which doesn't return error for non-existent keys.
Known limitations
N/A