-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add soroban-bench-utils
, add benchmark tests to measure metering accuracy
#956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
changed the title
Move instrumentation helpers to the host, add metering benchmark tests
Add Jul 18, 2023
soroban-bench-utils
, add benchmark tests to measure metering accuracy
graydon
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #710
This PR moves the instrumentation helpers from the
bench
to the host (only turned on for linux and macos), and added a new helper classHostTracker
to get the actual resource usage.Added two test contracts and run them with instrumentation turned on, here are the results comparing modeled vs actual usage:
Which looks decent, but the difference is hard to tell due to
VmInstantiation
taking up majority of the share.Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
The tracking_allocator dependency has been moved from dev to actual. Because theI've moved the tracking-related utils to a separate packageHostTracker
is used for "bench" as well (which is under featuretestutils
, but still needs the dependency). Alternatively we makemod instrumentation
a separate package and use it as a dev-dependency.soroban-bench-utils
to avoid the prod dependency.gloabal_tracker
contention.Only supports os="linux" and "macos", due to the cpu instruction counting library being only available there.The "other" os now has a stubInstructionCounter
that returns 0 always.