Fix panic-string-logging code path broken by recent dynamic-borrow fix. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Jul 21, 2023
graydon
force-pushed
the
fix-panic-string-logging
branch
from
00a6c17
to
ba2b1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #925 I accidentally changed the control flow in panic-recovery to a double-nested
if let. Unfortunately there's anelseafter the outer block, so if the secondif letfails we skip theelse.This results in an SDK test failure (
test_invoke_expect_string) which is blocking completion of an SDK update to the current env.This PR fixes it (and tightens up the comments).