Add new tests for error escalation from contract calls. #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Jul 27, 2023
graydon
force-pushed
the
test-contract-call-error-returns
branch
from
dd2f453
to
7e7d504
Compare
graydon
force-pushed
the
test-contract-call-error-returns
branch
from
7e7d504
to
283d97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that contract calls that return various
Errorall escalate toErr(Error)at the host / frame level.This is part of ensuring #522 but we also need to run the same tests up at the core level and ensure we route these all the way to transaction failures there.