Upgrade dalek to at least next-pre-release versions. #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dalek has now fully released v2.0.0 of the ed25519 crate too. I'll open a new PR about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #963 -- it turns out dalek only released a stable (4.0) of the curve25519 crate not the ed25519 crate -- they're still working on the latter. This PR does the work of upgrading to a prerelease state of both (4.0-rc.3 and 2.0-rc.3 respectively) which is .. probably identical API-wise to what we'll see on 4.0 and 2.0. But it's not stable yet.
I'm not 100% sure what to do here. I think it's probably better to move to their prereleases assuming an imminent and uneventful final (especially given how old and unmaintained the previous release had got). But that could also be taking a risk of immature or incompletely-tested new code we don't really want to take. Open to input.