Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if bumping past max_entry_expiration and and host function to retrieve max_entry_expiration #985

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Error if bumping past max_entry_expiration and and host function to retrieve max_entry_expiration #985

merged 5 commits into from
Aug 8, 2023

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Aug 4, 2023 •
edited
Loading

What

Resolves #973.

@sisuresh sisuresh requested review from graydon and a team as code owners August 4, 2023 19:33
@sisuresh sisuresh marked this pull request as draft August 4, 2023 20:16
@sisuresh sisuresh marked this pull request as ready for review August 4, 2023 20:21
dmkozh
dmkozh reviewed Aug 8, 2023
View reviewed changes
soroban-env-common/env.json Outdated Show resolved Hide resolved
dmkozh
dmkozh approved these changes Aug 8, 2023
View reviewed changes
soroban-env-common/env.json Outdated Show resolved Hide resolved
soroban-env-host/src/storage.rs Outdated Show resolved Hide resolved
@sisuresh sisuresh merged commit 4867132 into stellar:main Aug 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@graydon graydon Awaiting requested review from graydon graydon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce max expiration ledger
2 participants
@sisuresh @dmkozh