Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 21.7.3 #1354

Closed
wants to merge 2 commits into from
Closed

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    aa0781f View commit details
    Browse the repository at this point in the history
  2. Add compile errors when built with unsupported wasm features (#1353)

    ### What
    Add compile errors when built with unsupported wasm features
    reference-types and multivalue.
    
    ### Why
    Rust 1.82 is likely to ship with target feature reference-types and
    multivalue enabled on wasm builds. These target features are not
    supported by the Soroban Env in the current protocol 21 or next planned
    protocol 22. It's not trivial for developers to disable target features
    because of how the rustc compiler only exposes the ability to buildstd
    with nightly.
    
    These compile errors will prevent someone from building .wasm files with
    the sdk when either of those target features are enabled.
    
    A Rust version check is not being done because it's actually easier to
    do a target feature check, and in the off chain somehow Rust 1.82
    shipped without the target features enabled then the sdk could still be
    used with 1.82.
    
    Links:
    - https://discord.com/channels/897514728459468821/1289090985569026048
    - stellar/rs-soroban-env#1469
    - WebAssembly/tool-conventions#233
    
    ### Releasing
    This change will be merged to `main` targeting v22, then should be
    backported to a v21 patch release immediately following.
    
    (cherry picked from commit 6c45fb9)
    leighmcculloch committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1f81019 View commit details
    Browse the repository at this point in the history