Adapt SDK to changes to {Try,}{From,Into}Val in env crates. #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Jan 13, 2023
graydon
force-pushed
the
tryfromval-reform-take-8
branch
3 times, most recently
from
7115ddd
to
4237a60
Compare
graydon
changed the title
graydon
force-pushed
the
tryfromval-reform-take-8
branch
from
4237a60
to
e42a61d
Compare
graydon
force-pushed
the
tryfromval-reform-take-8
branch
3 times, most recently
from
1d03b51
to
7534553
Compare
graydon
force-pushed
the
tryfromval-reform-take-8
branch
from
7534553
to
ed99657
Compare
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the SDK to changes in stellar/rs-soroban-env#628 -- this variant finally worked ok. Very minor warts, lots of code removal.