Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs in specs for types #862

Merged
merged 13 commits into from
Feb 15, 2023
Merged

Add docs in specs for types #862

merged 13 commits into from
Feb 15, 2023

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Feb 11, 2023 •
edited
Loading

What

Add docs in specs for types.

Why

To further expand and fill out what we store docs for in specs.

@leighmcculloch
Copy link
Member Author

leighmcculloch commented Feb 11, 2023 •
edited
Loading

Todo:

  • Outer types (structs, enums, int enums, errors enums).
  • Struct fields.
  • Enum variants.
  • Tests.

@leighmcculloch leighmcculloch marked this pull request as ready for review February 13, 2023 23:08
@leighmcculloch leighmcculloch enabled auto-merge (squash) February 13, 2023 23:08
dmkozh
dmkozh approved these changes Feb 13, 2023
View reviewed changes
soroban-sdk/src/tests/contract_docs_enum.rs Outdated Show resolved Hide resolved
soroban-sdk/src/tests/contract_docs_enum_int.rs Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch merged commit adf4870 into main Feb 15, 2023
@leighmcculloch leighmcculloch deleted the docsinspecstypes branch February 15, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leighmcculloch @dmkozh