Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup wasm fetch methods #9

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Cleanup wasm fetch methods #9

merged 5 commits into from
Jul 29, 2024

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Jul 27, 2024

What

Remove get_remote_wasm function, it's moved to cli

Why

See discussion here
stellar/stellar-cli#1488 (comment)

Known limitations

N/A

leighmcculloch
leighmcculloch reviewed Jul 28, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the change here. Three asks inline.

src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch mentioned this pull request Jul 28, 2024
Merged
@Ifropc Ifropc merged commit 68a5bb2 into main Jul 29, 2024
6 checks passed
@Ifropc Ifropc deleted the wasm-cleanuo branch July 29, 2024 20:45
@willemneal
Copy link
Member

I missed this PR, but I do feel that perhaps we should make some other crate that acts like the js-stellar-sdk, as devs might want to have more connivence methods and it could be where the transaction builder lives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ifropc @willemneal @leighmcculloch