Add Validate trait and impl for ScVal variants that can be invalid (U63, Symbol, Bitset) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
Validatetrait and impl forScValvariants that can be invalid (ScVal::U63,ScVal::Symbol,ScVal::Bitset) regardless of any other context.Why
Facilitate users of the XDR validating that the ScVal types are valid. There are likely to be multiple places that we'll need to validate these XDR values.
Close #106
Known limitations
The
ScVal::Mapvariant and its type,ScMap, also need to be validated, but that is left as a todo! in this change and will be added in a follow up change.The
Validatetrait is simple and provides no inputs to address the future need of versioning that @graydon mentions in #106 (comment). We can extend the trait in the future, or create new traits and separate implementations for each version, as the need arises.