Run CI for the msrv and latest rust version #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run CI for the msrv and latest rust version. Run clippy and test for msrv, and check and test for latest.
Why
Now that stable releases of the lib have gone out we shouldn't require a new version of Rust in subsequent releases, so we should ensure that the lib continues to build on the msrv. We should also test the latest rust version too since many folks will upgrade to it.
The reason for clippy on msrv and check on latest is because clippy rules change dramatically from one release to the next. While the lib may pass the clippy rules on the msrv, it won't necessarily pass them on latest, because latest in this CI is truly latest available and not the latest we've updated the clippy rules for. We might want to change this in the future, but it's just one way to prevent us from being blocked on PRs because a new Rust was just released with new clippy rules.
Close stellar/rs-soroban-env#1311