Pick up new cost type for Secp256r1 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Apr 3, 2024
### What Resolves #807 by adding a new host function `verify_sig_ecdsa_secp256r1` for ECDSA signature verification using secp256r1 curve. The function accepts following inputs: - `public_key: BytesObject` containing the 65-byte SEC-1 uncompressed ECDSA public key - `msg_digest: BytesObject` a 32-byte hash of the message - `signature`: the 64-byte signature `(r, s)` serialized as fixed-width big endian scalars The function is gated behind protocol 21 (`min_supported_protocol = 21`). PR with the associated XDR changes: stellar/stellar-xdr#178, stellar/rs-stellar-xdr#355 #### Metering and Calibration Two new cost types have been newly added: - `Sec1DecodePointUncompressed`: constant cost type representing the cost to decode the `public_key` - `VerifyEcdsaSecp256r1Sig` : constant cost type represent the cost of ECDSA sig verification A prevous cost type `ComputeEcdsaSecp256k1Sig` has been renamed to `DecodeEcdsaCurve256Sig`, which represents the cost of deserializing both the `secp256k1` and `secp256r1` signatures. Calibration: - each new cost type mentioned above have been benchmarked and calibrated. - plus a few experimental types have been added to answer key questions regarding the host interface (will provide a supplemental doc soon). #### Testing Unit tests have been added to test against various forms of invalid inputs. In addition, two set of test vectors has been added in integration test: - [NIST test vectors](https://csrc.nist.gov/groups/STM/cavp/documents/dss/186-3ecdsatestvectors.zip) - Google's [wycheproof](https://github.com/C2SP/wycheproof) test vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pick up changes from stellar/stellar-xdr#178
Master issue: stellar/rs-soroban-env#807
Env PR: stellar/rs-soroban-env#1376
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]