Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync curr with next for p21 #359

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Apr 5, 2024

Rust change matching stellar/stellar-xdr#180

@graydon graydon marked this pull request as draft April 5, 2024 14:38
@graydon graydon force-pushed the sync-curr-with-next-for-p21 branch from 6c45948 to ac696dc Compare April 5, 2024 16:44
@graydon graydon changed the title WIP sync curr with next for p21 Sync curr with next for p21 Apr 5, 2024
@graydon graydon marked this pull request as ready for review April 5, 2024 16:44
@anupsdf anupsdf enabled auto-merge April 5, 2024 16:57
@anupsdf anupsdf added this pull request to the merge queue Apr 5, 2024
@graydon graydon mentioned this pull request Apr 5, 2024
9 tasks
Merged via the queue into stellar:main with commit 9cea8b7 Apr 5, 2024
10 checks passed
github-merge-queue bot pushed a commit to stellar/rs-soroban-env that referenced this pull request Apr 11, 2024
This is now ready to merge. Does the following:

- [x] take new XDR from
stellar/rs-stellar-xdr#359
  - [x] bump current protocol 20->21 and next 21->22 
- [x] remove `feature="next"` gates guarding protocol 21 functionality
(note: this is not _all_ `feature="next"` gates, some test the very
concept of next-ness and should remain)
  - [ ] defer to next PR: ~bump workspace version to 21.0.0~
  - [ ] defer to next PR: ~remove `feature="unstable-next-api"` gates~
  - [x] run observations for protocol 21
- [x] modify CI to run tests twice, once with TEST_PROTOCOL=20 and once
with TEST_PROTOCOL=21
- [x] modify recent VMCaller-using secp256r1 tests to go through the env
now that it supports those host functions
  - [x] fix all tests broken by the above

---------

Co-authored-by: Dmytro Kozhevin <dmytro@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants