Skip to content

Commit

Permalink
Remove pagingToken from getEvents (#297)
Browse files Browse the repository at this point in the history
  • Loading branch information
psheth9 authored Oct 2, 2024
1 parent 38807d3 commit 44db01f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions cmd/soroban-rpc/internal/methods/get_events.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ type EventInfo struct {
ContractID string `json:"contractId"`
ID string `json:"id"`

// Deprecated: PagingToken field is deprecated, please use Cursor at top level for pagination
PagingToken string `json:"pagingToken"`
InSuccessfulContractCall bool `json:"inSuccessfulContractCall"`
TransactionHash string `json:"txHash"`

Expand Down Expand Up @@ -555,7 +553,6 @@ func eventInfoForEvent(
Ledger: int32(cursor.Ledger),
LedgerClosedAt: ledgerClosedAt,
ID: cursor.String(),
PagingToken: cursor.String(),
InSuccessfulContractCall: event.InSuccessfulContractCall,
TransactionHash: txHash,
}
Expand Down
6 changes: 0 additions & 6 deletions cmd/soroban-rpc/internal/methods/get_events_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,6 @@ func TestGetEvents(t *testing.T) {
LedgerClosedAt: now.Format(time.RFC3339),
ContractID: "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
ID: id,
PagingToken: id,
TopicXDR: []string{value},
ValueXDR: value,
InSuccessfulContractCall: true,
Expand Down Expand Up @@ -796,7 +795,6 @@ func TestGetEvents(t *testing.T) {
LedgerClosedAt: now.Format(time.RFC3339),
ContractID: "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
ID: id,
PagingToken: id,
TopicXDR: []string{counterXdr, value},
ValueXDR: value,
InSuccessfulContractCall: true,
Expand Down Expand Up @@ -943,7 +941,6 @@ func TestGetEvents(t *testing.T) {
LedgerClosedAt: now.Format(time.RFC3339),
ContractID: strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
ID: id,
PagingToken: id,
TopicXDR: []string{counterXdr, value},
ValueXDR: value,
InSuccessfulContractCall: true,
Expand Down Expand Up @@ -1020,7 +1017,6 @@ func TestGetEvents(t *testing.T) {
LedgerClosedAt: now.Format(time.RFC3339),
ContractID: strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
ID: id,
PagingToken: id,
TopicXDR: []string{counterXdr},
ValueXDR: counterXdr,
InSuccessfulContractCall: true,
Expand Down Expand Up @@ -1093,7 +1089,6 @@ func TestGetEvents(t *testing.T) {
LedgerClosedAt: now.Format(time.RFC3339),
ContractID: "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
ID: id,
PagingToken: id,
TopicXDR: []string{value},
ValueXDR: value,
InSuccessfulContractCall: true,
Expand Down Expand Up @@ -1195,7 +1190,6 @@ func TestGetEvents(t *testing.T) {
LedgerClosedAt: now.Format(time.RFC3339),
ContractID: strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
ID: id,
PagingToken: id,
TopicXDR: []string{counterXdr},
ValueXDR: expectedXdr,
InSuccessfulContractCall: true,
Expand Down

0 comments on commit 44db01f

Please sign in to comment.