Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clippy #102

Merged
merged 3 commits into from
Jul 11, 2024
Merged

fix: clippy #102

merged 3 commits into from
Jul 11, 2024

Conversation

willemneal
Copy link
Member

No description provided.

@janewang janewang requested a review from dmkozh March 13, 2024 20:29
@2opremio
Copy link
Contributor

@willemneal is there a reason to downgrade the dependencies?

@willemneal
Copy link
Member Author

@2opremio This is really outdated. I rebase and repush

leighmcculloch
leighmcculloch approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to me like no logic is changing and looks fine.

@willemneal willemneal merged commit c8965d0 into main Jul 11, 2024
19 checks passed
@willemneal willemneal deleted the chore/clippy branch July 11, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@dmkozh dmkozh Awaiting requested review from dmkozh

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willemneal @2opremio @leighmcculloch