Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use CORE_IMAGE_BIN_PATH on e2e for core image, skip compile #222

Merged
merged 11 commits into from
Jun 18, 2024
Merged

use CORE_IMAGE_BIN_PATH on e2e for core image, skip compile #222

merged 11 commits into from
Jun 18, 2024

Conversation

sreuland
Copy link
Contributor

What

use CORE_IMAGE_BIN_PATH with CORE_IMAGE on e2e

Why

for core image, skip compile, to build e2e faster

@sreuland sreuland marked this pull request as draft June 18, 2024 04:54
@2opremio
Copy link
Contributor

Nice!! Thanks!

It still takes 22 mins thought!

@sreuland
Copy link
Contributor Author

Nice!! Thanks!

It still takes 22 mins thought!

yes cli make install_rust from source and the rpc make build-soroban-rpc targets take up the majority of that remaining build time, system-test can optionally do cargo install soroban-cli <ver> , but I've noticed that takes almost as much time as build from repo/source since the the crate install builds rust locally anyways.

@sreuland sreuland marked this pull request as ready for review June 18, 2024 18:34
@sreuland sreuland merged commit d5bdfa8 into stellar:main Jun 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2opremio 2opremio 2opremio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreuland @2opremio