go: Fix more linter problems #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
commented
Jun 20, 2024
Comment on lines
-254
to
+264
| reader.Seek(txIndex - 1) | ||
| if err != nil { | ||
| return lcm, ingest.LedgerTransaction{}, | ||
| errors.Wrapf(err, "failed to index to tx %d in ledger %d (txhash=%s)", | ||
| txIndex, lcm.LedgerSequence(), hash) | ||
| fmt.Errorf("failed to create ledger reader: %w", err) | ||
| } | ||
| err = reader.Seek(txIndex - 1) | ||
| if err != nil { | ||
| return lcm, ingest.LedgerTransaction{}, | ||
| fmt.Errorf("failed to index to tx %d in ledger %d (txhash=%s): %w", | ||
| txIndex, lcm.LedgerSequence(), hash, err) |
There was a problem hiding this comment.
This one was ugly (the seek error wasn't checked)
2opremio
force-pushed
the
fix-more-linter-problems
branch
from
7e25e20
to
32bc2e5
Compare
2opremio
force-pushed
the
fix-more-linter-problems
branch
2 times, most recently
from
78c719e
to
f66c6d2
Compare
2opremio
force-pushed
the
fix-more-linter-problems
branch
from
f66c6d2
to
d1e9fe3
Compare
psheth9
reviewed
Jun 20, 2024
psheth9
reviewed
Jun 20, 2024
| @@ -239,7 +243,7 @@ func TestGetTransactions_LedgerNotFound(t *testing.T) { | |||
| } | |||
|
|
|||
| response, err := handler.getTransactionsByLedgerSequence(context.TODO(), request) | |||
| expectedErr := errors.Errorf("[%d] ledger close meta not found: 2", jrpc2.InvalidParams) | |||
| expectedErr := fmt.Errorf("[%d] ledger close meta not found: 2", jrpc2.InvalidParams) | |||
There was a problem hiding this comment.
Why moving from errors package to fmt?
There was a problem hiding this comment.
Because our internal errors package uses an outdated implementation of error wrapping https://github.com/pkg/errors (which only made sense when the std library didn't implement it)
The std library now provides "errors" and fmt.Errorf()
There was a problem hiding this comment.
We should remove the package from stellar/go
2opremio
added a commit
to 2opremio/soroban-rpc
that referenced
this pull request
Jul 17, 2024
I broke it at stellar#228 It turns out that `github.com/stellar/go/support/errors.Wrapf` returns nil if the error is nil (which is different to how `errors.Errorf` behaves). I have looked at both stellar#228 and stellar#224 and this is the only instance in which we replaced `Wrapf` by `Errorf` where we don't first check the error for `nil`.
2opremio
added a commit
to 2opremio/soroban-rpc
that referenced
this pull request
Jul 17, 2024
I broke it at stellar#228 It turns out that `github.com/stellar/go/support/errors.Wrapf` returns nil if the error is nil (which is different to how `errors.Errorf` behaves). I have looked at both stellar#228 and stellar#224 and this is the only instance in which we replaced `Wrapf` by `Errorf` where we don't first check the error for `nil`.
2opremio
added a commit
that referenced
this pull request
Jul 17, 2024
I broke it at #228 It turns out that `github.com/stellar/go/support/errors.Wrapf` returns nil if the error is nil (which is different to how `errors.Errorf` behaves). I have looked at both #228 and #224 and this is the only instance in which we replaced `Wrapf` by `Errorf` where we don't first check the error for `nil`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.