Add a more generic getLedgerEntry rpc method #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
get-ledger-entry
branch
from
d92d37c
to
b10c416
Compare
paulbellamy
force-pushed
the
get-ledger-entry
branch
from
b10c416
to
7f27d79
Compare
added 2 commits
November 30, 2022 17:00
paulbellamy
force-pushed
the
get-ledger-entry
branch
from
47f08a3
to
e59af3c
Compare
|
Awesome. |
|
Yes, that is the issue, thanks. |
added 2 commits
November 30, 2022 19:08
paulbellamy
force-pushed
the
get-ledger-entry
branch
from
752f91d
to
2df357a
Compare
* Updating xdr for soroban-rpc * Trying the new core version * Fix nil pointer * Need to compare contract hash not contract code now * getLedgerEntry test checks code not hash * Fixing tests * update go mod/sum to reflect the latest soroban-xdr-next branch in go monorepo * Update sdk and env to latest crates * Fix up conversions and clippy * Need to use the sandbox passphrase in the sandbox * update test mocks for new contract ids * Updating contract ids for e2e Co-authored-by: tsachiherman <24438559+tsachiherman@users.noreply.github.com>
|
FYI: The e2e test on this will fail until quickstart is updated. |
sreuland
reviewed
Dec 2, 2022
sreuland
reviewed
Dec 2, 2022
sreuland
reviewed
Dec 2, 2022
sreuland
reviewed
Dec 2, 2022
sreuland
approved these changes
Dec 2, 2022
|
looks good, I didn't dig in too deep on the rust though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a new rpc
getLedgerEntrymethod to supersedegetContractData.Why
Because the contract storage has changed with the new xdr,
getContractDatacan no longer be used by soroban-cli to fetch the contract code. We could have added thegetContractCodeendpoint from the original spec. But, it's come up several times that actuallygetLedgerEntryis both lower-level and more useful.The plan will be to deprecate
getContractData, and remove it in favour ofgetLedgerEntryin the next release.Todo