Deprecate contract inspect #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
approved these changes
Oct 4, 2024
willemneal
reviewed
Oct 4, 2024
Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
fnando
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add deprecate notice to
contract inspectcommandWhy
#1528
We should add deprecate notice first before committing to removing the command
Known limitations
infotechnically doesn't supportxdr-base64-arraywhichinspectdoes. This shouldn't be an issue once we bring support of XDR streams to our JS tooling (this is already supported by RS tools)Alternatively, we can bring
xdr-base64-arraytoinfocommand