Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile: disable the fetch test #750

Merged
merged 2 commits into from
Jul 5, 2023
Merged

compile: disable the fetch test #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b280a42
disable the fetch test, since it's testing it against futurenet.
tsachiherman Jul 5, 2023
3b272e7
update boilerplate test.
tsachiherman Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/crates/soroban-spec-typescript/src/boilerplate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ mod test {
Ok(p)
}

// TODO : fix the test below :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this mention addressing the dependency on futurenet also, the pr's Why refers to this as the main reason test is not repeatable?

// the test below should verify only a certain subset of the files were copied
// rather then the entire directory.
#[ignore]
#[test]
fn test_project_dir_location() {
// TODO: Ensure windows support
Expand Down
1 change: 1 addition & 0 deletions cmd/crates/soroban-test/tests/it/invoke_sandbox.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ fn handles_kebab_case() {
.is_ok());
}

#[ignore]
#[tokio::test]
async fn fetch() {
// TODO: Currently this test fetches a live contract from futurenet. This obviously depends on
Expand Down