[SDP-1147] Store the admin tables in the admin schema, instead of the public schema #266

marcelosalloum · 2024-04-22T14:12:41Z

What

Store the admin tables in the admin schema, instead of the public schema.

Checklist:

Run the migration guide and check if things work as expected
- The migration guide needs one line to be updated
Create a tenant to make sure the tenant API is working
Run an e2e test

Why

Addresses https://stellarorg.atlassian.net/browse/SDP-1147.

Known limitations

[TODO or N/A]

Checklist

PR Structure

This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
This PR title and description are clear enough for anyone to review it.
This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

This PR adds tests for the new functionality or fixes.
This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

This is not a breaking change.
This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

Does the deployment work after merging?

stellar-jenkins · 2024-04-22T14:13:46Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-22T15:34:43Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-22T15:36:28Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-22T15:51:17Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-22T15:55:07Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-22T15:56:32Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

### What Update the single-tenant to multi-tenant migration guide with the following changes: * Update the status requirements saying that the only payments/submitter_transactions statuses that need to be solved before the migration are PENDING/PROCESSING * Reorganize the content * Add extra sections with more info * Include new commands and SQL queries to make the migration easier. * Add TODOs: - [x] stellar/stellar-disbursement-platform-backend#262 - [ ] stellar/stellar-disbursement-platform-backend#266 - [ ] https://stellarorg.atlassian.net/browse/SDP-1148

stellar-jenkins · 2024-04-22T18:38:58Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

marwen-abid

LGTM! This is great! Thank you for all the extra simplifications of the schemas

marwen-abid · 2024-04-23T00:08:38Z

cmd/db/db.go

@@ -203,8 +203,19 @@ func (c *DatabaseCommand) adminMigrationsCmd(ctx context.Context, globalOptions
 	}

 	executeMigrationsFn := func(ctx context.Context, dir migrate.MigrationDirection, count int) error {
-		if err := ExecuteMigrations(ctx, globalOptions.DatabaseURL, dir, count, migrations.AdminMigrationRouter); err != nil {
-			return fmt.Errorf("executing migrations for %s: %w", adminCmd.Name(), err)
+		dbURL, err := router.GetDNSForAdmin(globalOptions.DatabaseURL)


Not related to this PR, but I believe this should be switched to GetDSNForAdmin()

db/migrations/admin-migrations/2023-10-16.0.add-tenants-table.sql

marwen-abid · 2024-04-23T00:15:42Z

db/migrations/admin-migrations/2023-10-16.0.add-tenants-table.sql

 CREATE TYPE tenant_status AS ENUM ('TENANT_CREATED', 'TENANT_PROVISIONED', 'TENANT_ACTIVATED', 'TENANT_DEACTIVATED');

 CREATE TABLE tenants
 (
    id VARCHAR(36) PRIMARY KEY DEFAULT public.uuid_generate_v4(),
    name text NOT NULL,
-    email_sender_type email_sender_type DEFAULT 'DRY_RUN'::email_sender_type,
-    sms_sender_type sms_sender_type DEFAULT 'DRY_RUN'::sms_sender_type,
    enable_mfa boolean DEFAULT true,
    enable_recaptcha boolean DEFAULT true,


Given that we're simplifying the schema, it would be good to remove enable_mfa and enable_recaptcha. They were dropped in 2024-03-01.alter-tenants-table-drop-enable-mfa-and-recaptcha.sql

marwen-abid · 2024-04-23T00:16:21Z

db/migrations/admin-migrations/2023-10-16.0.add-tenants-table.sql

 CREATE TYPE tenant_status AS ENUM ('TENANT_CREATED', 'TENANT_PROVISIONED', 'TENANT_ACTIVATED', 'TENANT_DEACTIVATED');

 CREATE TABLE tenants
 (
    id VARCHAR(36) PRIMARY KEY DEFAULT public.uuid_generate_v4(),
    name text NOT NULL,
-    email_sender_type email_sender_type DEFAULT 'DRY_RUN'::email_sender_type,
-    sms_sender_type sms_sender_type DEFAULT 'DRY_RUN'::sms_sender_type,
    enable_mfa boolean DEFAULT true,
    enable_recaptcha boolean DEFAULT true,
    cors_allowed_origins text[] NULL,


cors_allowed_origins was dropped in 2023-11-14.0.drop-unused-cors-column.sql

marwen-abid · 2024-04-23T00:17:05Z

db/router/router.go

+}
+
+// Helper function to set the search_path for the schema.
+func getDSNWithFixedSchema(dataSourceName, schemaName string) (string, error) {


stellar-jenkins · 2024-04-23T14:08:13Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

…move occurrences of email_sender_type and sms_sender_type.

…move occurrences of enable_mfa and enable_recaptcha.

stellar-jenkins · 2024-04-23T14:25:39Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr266.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr266.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr266.previews.kube001.services.stellar-ops.com

* [SDP-1139] sdp: add SDP multi-tenant migration doc (#394) * feat: add SDP multi-tenant migration doc * chore: address PR comments * [SDP-1056] sdp: add SDP Admin API spec (#397) * feat: add SDP Admin API spec * chore: address PR comments * fix: remove distribution_account field * SDP-1054 update design and architecture docs * Update the "Getting Started" section. * chore: update SDP docs build (#440) When running the `yarn api` these files are rebuilt due to a new authenticate method added (`Basic Auth`). This PR only updates these files to the latest version. The changes are related to this #397. * [SDP-1100] Default tenant endpoint (#455) This PR adds the default tenant endpoint that sets a tenant as the default in the system. --------- Authored-by: Caio Teixeira <caio.xd63@hotmail.com> * [SDP-1151] Update single-tenant to multi-tenant migration guide (#496) ### What Update the single-tenant to multi-tenant migration guide with the following changes: * Update the status requirements saying that the only payments/submitter_transactions statuses that need to be solved before the migration are PENDING/PROCESSING * Reorganize the content * Add extra sections with more info * Include new commands and SQL queries to make the migration easier. * Add TODOs: - [x] stellar/stellar-disbursement-platform-backend#262 - [ ] stellar/stellar-disbursement-platform-backend#266 - [ ] https://stellarorg.atlassian.net/browse/SDP-1148 * [SDP-1151] Polish the single-tenant to multi-tenant migration guide (#511) * [SDP-1157] add `Configuring the SDP` page (#512) * SDP-1157 adding `Configuring the SDP` page * SDP-1157 adding `Configuring the SDP` page * SDP-1157 address PR comments * SDP-1157 move sdp API under api-reference folder * Fix broken link * Change architecture diagram * Update instructions with the updated field name. * add tenant resolution and multi-tenant subdomain info. (#578) * add tenant resolution and multi-tenant subdomain info. * address PR comments * Enforce the necessity to include the home domain in the SDP SEP-10 challenge GET request (#654) ### Why To keep the docs up to date with the code. This is now required in the multitenant instance. * [SDP] Polish the docs for the multitenant 2.0.0 release (#656) ### Changes - Add the missing DELETE /tenants/:id API documentation - Update the request and response bodies in the /tenants API. - Updated the checksum on the .api.mdx files by running `yarn api` --------- Co-authored-by: Caio Teixeira <caio.xd63@hotmail.com> Co-authored-by: Erica <erica.liu@stellar.org> Co-authored-by: Marcelo Salloum dos Santos <marcelosalloum@gmail.com> Co-authored-by: Marcelo Salloum <marcelo@stellar.org>

* Changing "Soroban CLI" to "Stellar CLI" * Update soroban-cli version. (#634) * Update some CLI commands * Remove Deadlink - Stellar Authenticator (#637) * Update setup.mdx (#644) The soroban-cli version in this doc is outdated and will give the following error when invoking a deployed contract: "error: xdr processing error: xdr value invalid" As specified here an update of the CLI version is needed: https://stellar.org/blog/developers/protocol-21-upgrade-guide * Update smart-contract-deployment.mdx (#645) The it is an issue in the vault contract's withdraw function which will incorrectly update the value of Reserve. In this line let balance = get_token_balance(&e); balance is updated AFTER the transfer of the user deposit + yield has already occurred. Thus the balance fetched is already the current "reserve" balance of the Vault. So when the following line of code executes: put_reserve(&e, balance - amount); the Reserve is updated to the balance of the Vault contract - the amount withdrawn by the user, so it will count the withdrawn 2 times. Indeed when following the test the result from "get_rsrvs" in the first scenario will be : "-1" Initial balance of the Vault: 200 - amount: 100 + yield: 1 (from the transfer) - amount: 100 (from the put_reserve input). For further improvements the get_rsrvs should only account for the amount of reward tokens that the vault is holding which can be useful to obtain the deposited amount (vault balance - reserves). Additionally the --wasm argument in the "invoke" command is not needed and it was removed. * [SDP-1054] Updating Stellar Docs for SDP multi-tenant (#407) * [SDP-1139] sdp: add SDP multi-tenant migration doc (#394) * feat: add SDP multi-tenant migration doc * chore: address PR comments * [SDP-1056] sdp: add SDP Admin API spec (#397) * feat: add SDP Admin API spec * chore: address PR comments * fix: remove distribution_account field * SDP-1054 update design and architecture docs * Update the "Getting Started" section. * chore: update SDP docs build (#440) When running the `yarn api` these files are rebuilt due to a new authenticate method added (`Basic Auth`). This PR only updates these files to the latest version. The changes are related to this #397. * [SDP-1100] Default tenant endpoint (#455) This PR adds the default tenant endpoint that sets a tenant as the default in the system. --------- Authored-by: Caio Teixeira <caio.xd63@hotmail.com> * [SDP-1151] Update single-tenant to multi-tenant migration guide (#496) ### What Update the single-tenant to multi-tenant migration guide with the following changes: * Update the status requirements saying that the only payments/submitter_transactions statuses that need to be solved before the migration are PENDING/PROCESSING * Reorganize the content * Add extra sections with more info * Include new commands and SQL queries to make the migration easier. * Add TODOs: - [x] stellar/stellar-disbursement-platform-backend#262 - [ ] stellar/stellar-disbursement-platform-backend#266 - [ ] https://stellarorg.atlassian.net/browse/SDP-1148 * [SDP-1151] Polish the single-tenant to multi-tenant migration guide (#511) * [SDP-1157] add `Configuring the SDP` page (#512) * SDP-1157 adding `Configuring the SDP` page * SDP-1157 adding `Configuring the SDP` page * SDP-1157 address PR comments * SDP-1157 move sdp API under api-reference folder * Fix broken link * Change architecture diagram * Update instructions with the updated field name. * add tenant resolution and multi-tenant subdomain info. (#578) * add tenant resolution and multi-tenant subdomain info. * address PR comments * Enforce the necessity to include the home domain in the SDP SEP-10 challenge GET request (#654) ### Why To keep the docs up to date with the code. This is now required in the multitenant instance. * [SDP] Polish the docs for the multitenant 2.0.0 release (#656) ### Changes - Add the missing DELETE /tenants/:id API documentation - Update the request and response bodies in the /tenants API. - Updated the checksum on the .api.mdx files by running `yarn api` --------- Co-authored-by: Caio Teixeira <caio.xd63@hotmail.com> Co-authored-by: Erica <erica.liu@stellar.org> Co-authored-by: Marcelo Salloum dos Santos <marcelosalloum@gmail.com> Co-authored-by: Marcelo Salloum <marcelo@stellar.org> * Rewriting scaling documentation (#659) * rpc: add getFeeStats method documentation (#660) * rpc: add getFeeStats method * Address review feedback * Remove unneeded stop * Add some description updates --------- Co-authored-by: Jane Wang <janewang@Janes-MacBook-Pro.local> * Soroban RPC: Add document for getVersionInfo RPC (#661) * Add document for getVersionInfo RPC * update info * Add captive core info * Add a table of hardware requirements for various node types (#568) * add a doc with a requirements comparison table * add some sidebar content for new-ish section * adjust some heading config for platforms pages * Fix command for adding new networks. (#667) * Adding Tokens Overview (wayfinding) (#570) * Adding Tokens Overview (wayfinding) * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * formatting * more updates * update copy * couple nits * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com> * update wording * update note * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * G & C addresses * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * Update docs/smart-contracts/tokens/wayfinding.mdx Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> * wording * formatting --------- Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com> * Categorize Learn Section (#646) * Categorize Learn Section * moving things around * fix links * more links * mas links * beaucoup links * mais links * authorization heading fix * message * little nits * Fix link (#675) * Learn section redirects (#678) * Add examples of invoking contracts using Python SDK and Java SDK. (#643) * Add examples of calling contracts using Python SDK and Java SDK * rename file * fix js example * Add hubble diagrams and data dicts (#670) Add hubble diagrams and data dicts * Add Passkey Library session to meeting notes (#681) * update meeting notes * Update 2024-06-13.mdx * Update 2024-06-13.mdx * Update 2024-06-13.mdx --------- Co-authored-by: Tyler van der Hoeven <hi@tyvdh.com> * Add Ortege to Block Explorers (#671) * Add Ortege to Block Explorers * Update developer-tools.mdx * Update Software Versions for Protocol 21: Mainnet (#685) * Update Software Versions for Protocol 21: Mainnet * adding versions back to be updated * rpc: Add `getTransactions` documentation (#636) * Add getTransactions documenation - 1 * Add getTransactions documentation - 2 * Add getTransactions documentation - 4 * Refactor Pagination changes * Refactor the params object in getTransactions examples * Change naming to only RPC * Change description of diagnosticEventsXdr * Add "items" * Update openrpc/src/methods/getTransactions.json Co-authored-by: George <Shaptic@users.noreply.github.com> * Update openrpc/src/schemas/Cursor.json Co-authored-by: George <Shaptic@users.noreply.github.com> * Update openrpc/src/schemas/Pagination.json Co-authored-by: George <Shaptic@users.noreply.github.com> * Small changes - 1 * Remove links - 1 * Remove links - 2 * Fix broken TOID link --------- Co-authored-by: George <Shaptic@users.noreply.github.com> * Updates to Getting Started Docs (#674) * Update soroban output to current 21.x state * Fix naming for HelloContractClient * Consistent directory names * formatting and link --------- Co-authored-by: Bri <92327786+briwylde08@users.noreply.github.com> * Add more detail to overlay survey instructions (#653) * Add more detail to overlay survey instructions This change adds some additional instructions to the overlay survey section of the admin guide. Specifically, it adds: * Instructions on how to use the overlay survey script. * Information about the `nonce` field in the "start/stop collecting" messages. * Explicit instructions on how to opt-out of the survey. * Recommendations for collecting phase durations. * Small tweaks to fix grammar/formatting/example errors found while editing the section * Add links * Add admin-guide for hubble (#669) Add admin-guide for hubble * typo fix in cli guid (#693) * Update docs/smart-contracts/getting-started/setup.mdx Co-authored-by: Nando Vieira <me@fnando.com> * Changing "Soroban CLI" to "Stellar CLI" * Update some CLI commands * Add more cli updates * Update to stellar cli * Fix path --------- Co-authored-by: Nando Vieira <me@fnando.com> Co-authored-by: Jane Wang <janewang@Janes-MacBook-Pro.local> Co-authored-by: Ricky Lindenhovius <1669379+xiv@users.noreply.github.com> Co-authored-by: FrankFourier <84725957+Frank-Fourier@users.noreply.github.com> Co-authored-by: Marwen Abid <marwen.abid@stellar.org> Co-authored-by: Caio Teixeira <caio.xd63@hotmail.com> Co-authored-by: Erica <erica.liu@stellar.org> Co-authored-by: Marcelo Salloum dos Santos <marcelosalloum@gmail.com> Co-authored-by: Marcelo Salloum <marcelo@stellar.org> Co-authored-by: Molly Karcher <molly@stellar.org> Co-authored-by: Alfonso Acosta <fons@syntacticsugar.consulting> Co-authored-by: Prit Sheth <124409873+psheth9@users.noreply.github.com> Co-authored-by: Elliot Voris <elliot@stellar.org> Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com> Co-authored-by: Jun Luo <4catcode@gmail.com> Co-authored-by: chowbao <simon.chow765@gmail.com> Co-authored-by: Julian Martinez <73849597+Julian-dev28@users.noreply.github.com> Co-authored-by: Tyler van der Hoeven <hi@tyvdh.com> Co-authored-by: Aditya Vyas <adityavyas17@gmail.com> Co-authored-by: George <Shaptic@users.noreply.github.com> Co-authored-by: Pam S <pamela.selle@gmail.com> Co-authored-by: Brett Boston <bboston7@users.noreply.github.com> Co-authored-by: Rahul Soshte <rahul.soshte4771@gmail.com>

marcelosalloum self-assigned this Apr 22, 2024

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 14:12 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 14:12 — with GitHub Actions Inactive

marcelosalloum force-pushed the marcelo/SDP-1147-admin-schema-pt2 branch from b1b9ed4 to 61d4709 Compare April 22, 2024 15:33

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 15:33 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 15:33 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 15:35 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 15:35 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 15:50 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 15:50 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 15:54 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 15:54 — with GitHub Actions Inactive

marcelosalloum force-pushed the marcelo/SDP-1147-admin-schema-pt2 branch from 097ad99 to 53db3a2 Compare April 22, 2024 15:55

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 15:55 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 15:55 — with GitHub Actions Inactive

marcelosalloum changed the title ~~(WIP) [SDP-1147] Admin schema pt2~~ [SDP-1147] Store the admin tables in the admin schema, instead of the public schema Apr 22, 2024

marcelosalloum requested a review from a team April 22, 2024 15:59

marcelosalloum marked this pull request as ready for review April 22, 2024 16:02

marcelosalloum mentioned this pull request Apr 22, 2024

[SDP-1151] Update single-tenant to multi-tenant migration guide stellar/stellar-docs#496

Merged

3 tasks

marcelosalloum temporarily deployed to Anchor Integration Tests April 22, 2024 18:38 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 22, 2024 18:38 — with GitHub Actions Inactive

marwen-abid approved these changes Apr 23, 2024

View reviewed changes

marcelosalloum force-pushed the marcelo/SDP-1147-admin-schema-pt2 branch from bf2a268 to f479c5e Compare April 23, 2024 14:06

marcelosalloum temporarily deployed to Anchor Integration Tests April 23, 2024 14:07 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 23, 2024 14:07 — with GitHub Actions Inactive

marcelosalloum force-pushed the marcelo/SDP-1147-admin-schema branch from b51454d to 98ae547 Compare April 23, 2024 14:13

Base automatically changed from marcelo/SDP-1147-admin-schema to develop April 23, 2024 14:22

marcelosalloum added 9 commits April 23, 2024 11:22

Running admin migrations in its own schema

7645b95

Fixing tests.

eb25917

Improve code reusability when building the DNS per schema.

7e45b8d

Polishes.

f562d0b

Simplify method signature.

ab76aa9

Since the admin migrations moved to a new schema, it's a chance to re…

64dc7f0

…move occurrences of email_sender_type and sms_sender_type.

Fix typo: DNS -> DSN.

9085e84

Since the admin migrations moved to a new schema, it's a chance to re…

3b7a523

…move occurrences of enable_mfa and enable_recaptcha.

Fix method description.

6b0e068

marcelosalloum force-pushed the marcelo/SDP-1147-admin-schema-pt2 branch from f479c5e to 6b0e068 Compare April 23, 2024 14:24

marcelosalloum temporarily deployed to Anchor Integration Tests April 23, 2024 14:24 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 23, 2024 14:24 — with GitHub Actions Inactive

marcelosalloum merged commit 7384e59 into develop Apr 23, 2024
10 checks passed

marcelosalloum deleted the marcelo/SDP-1147-admin-schema-pt2 branch April 23, 2024 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SDP-1147] Store the admin tables in the admin schema, instead of the public schema #266

[SDP-1147] Store the admin tables in the admin schema, instead of the public schema #266

marcelosalloum commented Apr 22, 2024 •

edited

Loading

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

marwen-abid left a comment

marwen-abid Apr 23, 2024

marwen-abid Apr 23, 2024

marwen-abid Apr 23, 2024

marwen-abid Apr 23, 2024

stellar-jenkins commented Apr 23, 2024

stellar-jenkins commented Apr 23, 2024

[SDP-1147] Store the admin tables in the admin schema, instead of the public schema #266

[SDP-1147] Store the admin tables in the admin schema, instead of the public schema #266

Conversation

marcelosalloum commented Apr 22, 2024 • edited Loading

What

Why

Known limitations

Checklist

PR Structure

Thoroughness

Configs and Secrets

Release

Deployment

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

stellar-jenkins commented Apr 22, 2024

marwen-abid left a comment

Choose a reason for hiding this comment

marwen-abid Apr 23, 2024

Choose a reason for hiding this comment

marwen-abid Apr 23, 2024

Choose a reason for hiding this comment

marwen-abid Apr 23, 2024

Choose a reason for hiding this comment

marwen-abid Apr 23, 2024

Choose a reason for hiding this comment

stellar-jenkins commented Apr 23, 2024

stellar-jenkins commented Apr 23, 2024

marcelosalloum commented Apr 22, 2024 •

edited

Loading